DKPmon Master loot distribution
Working through the kinks of this addon (very difficult with limited info on the site) and I have figured most of what I need. However when trying to distribute the loot by right clicking and clicking "Distribute via Masterlooter" it gives me the pop up asking if I'm "positive that you want to give [name of item] to [name of person] via materlooter? I select yes and it doesn't do anything and i'm presented with this lua error
Message: Interface\AddOns\DKPmon\Looting\lootitem.lua:416: Usage: GetMasterLootCandidate(slot, index)
Time: 07/05/15 22:05:10
Count: 2
Stack: (tail call): ?
[C]: ?
[C]: in function `GetMasterLootCandidate'
Interface\AddOns\DKPmon\Looting\lootitem.lua:416: in function `MasterLootItem'
Interface\AddOns\DKPmon\Looting\lootitem.lua:325: in function `OnAccept'
Interface\FrameXML\StaticPopup.lua:4082: in function `StaticPopup_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>
Locals: (*temporary) = "LeftButton"
(*temporary) = false
(*temporary) = <function> defined =[C]:-1
Any fixes or is this functionality not supported?
Hello,
I've gone in to test this and was unable to reproduce the lua error. What I did was get into a group and convert to raid. Set the raid to Master Looter and went into RFC. I made sure that my CT_RaidTracker was set to DKPMon Logging Mode. I then killed the first boss and began the bidding process on the item. I set the item to a cost of 10, opened bidding, placed my bid, closed bidding and selected myself as the winner and deducted the point. Once I did that, I right clicked the item in the loot panel from the boss and clicked Assign Loot, selected myself to receive the loot and it was placed in my inventory with no lua errors.
Could you describe how your steps were different? I never saw an option called "Distribute via Masterlooter" so I'm not exactly sure how to test that.
Make sure you include a list of all the addons that you use in regards to looting as well as your settings. It is important to note that settings within CT_RaidTracker and DKPMon can both affect each other.
It would probably be best for you to email this to support@gamerlaunch.com. This way you'll be able to include files if needed. Speaking of which, for me to know exactly what your settings are, you could send me those files.
The files containing your settings can be found in World of Warcraft/WTF/Account/ACCOUNTNAME/SavedVariables
The two files you will need to send me are DKPmon.lua and GuildLaunchCT_RaidTracker.lua
-Brian
First off that is not the master loot function I was talking about. In dkpmon itself you can distribute loot by right clicking the item AFTER announcing winners but BEFORE deducting points. What you described is just the built in game master loot.
Secondly to eliminate any and all variables I ran this test without any addons (made a bare folder) with no game settings (made a new wtf folder) and only downloaded the raidleader suite from wow interface. The only settings I changed were "Load DKPmon Settings" in CT_RaidTracker Options, I enabled "Log events to Guild Launch Raid Tracker" under the dkpmon logging settings, and I set loot threshold to common. The only wow settings I changed were windowed borderless, for my sanity. I kept all other dkpmon settings default even though I normally use silentbid, though that should not effect the outcome.
Entered RFC, set to master looter, started logging, killed first boss and started loot
Assigned the loot to 10, opened bidding, bid.
I am not sure how fixed dkp works, again I have been working with silent bid. Even though I assigned myself 20dkp in the pool, and assigned the item as 10, and it accepts my bid, it still said the winner was D/E.
So I just made myself the DE person....moving on
After bidding ends and d/e is shown as winner I then announce. At this point I can right click the item and it gives me the option to "Distribute via Masterlooter" I click that and it says "Are you positive you want to give [item name] to Disenchant via masterlooter?" *note when I have the addon actually working with my loot system it sees me as the winner just fine and even says my name to give it to* I click yes and the previously mentioned Lua error appears
Message: Interface\AddOns\DKPmon\Looting\lootitem.lua:416: Usage: GetMasterLootCandidate(slot, index)
Time: 07/06/15 20:55:39
Count: 1
Stack: [C]: in function `GetMasterLootCandidate'
Interface\AddOns\DKPmon\Looting\lootitem.lua:416: in function `MasterLootItem'
Interface\AddOns\DKPmon\Looting\lootitem.lua:325: in function `OnAccept'
Interface\FrameXML\StaticPopup.lua:4082: in function `StaticPopup_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>
Locals: (*temporary) = 1
No logging or addon interference, just simply unsupported feature.... and from the sounds of it a feature that even you yourself didn't know existed? o.o
I feel for you though, I don't have much coding experience, but I did pick through the code trying to make other changes and its a spaghetti mess in there.
Hope this cleared things up a little, if you need more info or still need me to email I can
Wom-d,
Thanks for the feedback and info. I'm sure Brian can get that fixed for you. In terms of the addon, documentation is our next step for it and recreating that documentation in our uservoice site. Brian has gotten ahead of the update curve for the most part and is ready to tackle that. It could definitely use better documentation.
In terms of code and such the addons have gone through a few hands. The code is pretty good, but there is a lot of abstraction and LUA makes that abstraction very difficult to follow. There is also lots and lots of library code we did not write. It's one of the more complex addons out there with its own messaging layer and some interesting things going on.
Here is some of the old documentation that might help you out:
https://sites.google.com/site/dkpmon/
http://glmods.guildlaunch.com/
We'll work on massaging these into more robust documentation in uservoice.
Any progress on this?
had my first "live" night with the addon last night and everything worked very well. had an issue with the chest on the first boss not popping up loot, but that might have just been the chest itself that was bugged because it wouldn't let us loot it after that either. also had trouble tracking hellfire high council in ctraidtracker but I may have been using 6.37 still, dkpmon picked it up fine.
also is there any way to add an item to the bidding window? BOE drops are personal loot now but our guild gives it to master looter and still does bidding, but there is no way to track or initiate this. Should we just do manual whisper bids and then add it into ctraidtracker as custom event?
another thing that is more quality of life, but the award frame pops up after loot is done so any dkp awarded for the boss isn't used for looting unless I manually open the window when boss dies and award. Is there an easy way to have it pop up automatically when boss dies? or even when opening the loot window? -update- I moved DKPmon.Awarding:Show() from the deduct points function to the loot frame show function. Hopefully will accomplish what I am looking for
Hey Wom-d,
I have been taking a look at this and haven't quite figured it out yet. You are correct, I did not know about the Distribute via Masterlooter option. The addons functionality is quite large and I learn something new of it all the time haha. As Stephen said, it's been in quite a few hands and I'm at the bottom of that list.
I noticed you mentioned that the loot is always assigned to the disenchanter as the winner, I thought this was a bug at first too. What you have to do is left click the item in the DKPmon loot window and it will allow you to change who the winner is. You should be able to select Bank, Disenchanter, or any of the players who bid on the item. It will even list the total DKP that each bidding member has.
Anyway, to your bug report. This is indeed a bug and one that kind of fell through the cracks since I wasn't aware it was there in the first place. It looks like what is causing the bug has something to do with the new naming convention since cross-realm became integrated so deeply. Just last week I fixed a bug in our roster importing as a result of two characters, same name, different realm. Complicated stuff!
I will keep you updated on this. For now, you should be able to use the traditional WoW master loot window and some of the manual data entry until I get this fixed up!
-Brian
Hate to pile on, but found some more things tonight
-first boss hellfire assault chest does not bring up the dkpmon loot window and when brought up manually it does not propagate the item list so we couldn't do any bidding on the loot.
-hellfire high council is still not recognized by ctraidtracker. (my guild just made a custom event on the site so when it pops up as trash mob we can just change it to that) not a huge deal but worth mentioning
-item tie. I have seen the code for this and it seems solid so I'm not sure why this happened, but two people bid 250 on an item. It did the internal roll and picked one but then was going to charge 100 (our min bid). Was I supposed to manually select the winning bidder after the roll even though it said one of them had won?
-multiple items with the same name like tier pieces seemed to cause some issues in the mod with calculating next highest winner. So even though one person bid 300 and another bid 250 it was again going to charge 100.
sorry these are vague and difficult to reproduce, but figured it was worth keeping on the radar if any other information pops up
For Hellfire Assault, I know the chest is weird and only one person can look at it at a time. I thought I saw the items display in the DKPmon loot window when I personally was able to open the chest.
Hellfire High Council is a weird one. I've seen it track before, but it is very unreliable. How we have to do the tracking on them is to watch for their yells when they die. I haven't figured out what is so unreliable about doing it that way, but it proves unreliable. I wish there was a better way around it, but I haven't found it yet.
As for bidding on loot, this is definitely something I could figure out better. I could not convince my guild to go with DKP so I don't get to test it in a real environment, just small tests in RFC. I think you should be able to override the cost of the item at the end of bidding if the item cost is not adjusted to the actual bid. You should be able to do that by right clicking the item. (Do you recall a point in time where the addon would automatically change the cost of the item to highest bid?)
Multiple items with the same name, that sounds like a nightmare. Could you describe what happens when you open bidding when two of the same items drop? I would think you could just put one of them up for bidding at a time and do it that way.
Thank you for all the reports! It really does help.
-Brian